-
Notifications
You must be signed in to change notification settings - Fork 4
Add workflow for bumping version #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@deansheather my current thinking is that the |
Is there no way to do this from within the coder-cli release itself? Could just give coder-cli an SSH key with permission to do this stuff |
Yes that is an option, we could move this workflow code to coder-cli. I do think the additional authentication complexity is a considerable downside to that approach though. I think we'd also need to create a PAT for |
You'd still need code in coder-cli either way, so if you put the whole thing in coder-cli then you avoid having code in two places |
The template living in a separate repo is arguably worse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
./ci/scripts/gen-coder-cli-formula.sh ${{ github.event.inputs.version }} | ||
git diff | ||
git checkout -b bump-coder-cli-${{ github.event.inputs.version }} | ||
git add coder-cli.rb | ||
git commit -m "feat: bump coder-cli version to v${{ github.event.inputs.version }}" | ||
git push --set-upstream origin bump-coder-cli-${{ github.event.inputs.version }} | ||
gh pr create \ | ||
--title="bump coder-cli version to v${{ github.event.inputs.version }}" \ | ||
--body="" \ | ||
--reviewer cmoog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to a separate script file.
This has gotten a bit stale. Closing for now. We should first consider using something like https://github.com/goreleaser/goreleaser |
No description provided.